Fix story printing when there are multiple periods #4939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the story overview UI only shows the story of one period at a time, we should also only print the story of that period when using the quick print feature.
Also, I fixed a wrong
useAsyncDatacall in nuxt print.useAsyncDatarequires a string key as the first argument, and for all calls touseAsyncDatawith the same key, the same result data is returned. This led to nuxt print always printing the last period of the camp.There are more wrong usages of
useAsyncDatain nuxt print, but I think we should fix these separately, in order not to block this supposedly small fix PR. I wasn't able to easily fix a connected issue in nuxt print that only happens locally: When using the print configurator to print a single activity, nuxt print outputsError: props.scheduleEntry._meta is undefined.