Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(performance): use subresources & uriTemplate property to avoid … #4940

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

usu
Copy link
Member

@usu usu commented Apr 13, 2024

…large unnecessary join tables

fixes #4927

The number of queries is a bit higher, but this avoids the large join table generated by the previous query.

Inspired by #3610 and by BacLuc#208

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also like to test it

@@ -13312,7 +13374,7 @@ components:
items:
$ref: '#/components/schemas/DayResponsible-read_Day.DayResponsibles'
readOnly: true
type: array
type: unknown_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

@usu usu requested a review from pmattmann April 13, 2024 21:58
@pmattmann pmattmann added the deploy! Creates a feature branch deployment for this PR label Apr 13, 2024
Copy link

github-actions bot commented Apr 13, 2024

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least 25% better than before (with tiny requests)

@manuelmeister manuelmeister mentioned this pull request Apr 14, 2024
@pmattmann pmattmann added this pull request to the merge queue Apr 14, 2024
Merged via the queue into ecamp:devel with commit 06b626f Apr 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slow query: Show single period
4 participants