Refactor to classes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sieht für mich gut aus. Hab anstatt Kommentare mal versucht auf dem aufzubauen (siehe letzten Commits). Git diff hat etwas Mühe, das Ganze sauber darzustellen.
|
carlobeltrame
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Gefällt mir sehr gut! Merci! Ist tatsächlich viel simpler so wenn wir die Dependencies explizit übergeben, das passiert gar nicht an so vielen Orten wie ich dachte. Und so ists viel sauberer weil wir später für #2 die einzelnen Klassen einfach fix exportieren können.
Mir haben noch die $reload, $post etc. Methoden auf den LoadingStoreValues gefehlt, sowie Tests dafür. Diese habe ich jetzt ergänzt. Der PR ist aus meiner Sicht ready zum mergen.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Open this as a pull request do have a place for discussion