Skip to content

Commit

Permalink
Change the 'parent' attribute of direct public subfolders (#1316)
Browse files Browse the repository at this point in the history
* fix: change the 'parent' attribute of direct public subfolders so folder traversal finds these folders

* fix: parent method is a property

* fix: roots do not have a setter

---------

Co-authored-by: Erik Cederstrand <ekc@novozymes.com>
  • Loading branch information
ecederstrand and Erik Cederstrand committed Jun 9, 2024
1 parent c310c65 commit 3c13440
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions exchangelib/folders/roots.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,19 @@ def __init__(self, **kwargs):
if self._distinguished_id:
self._distinguished_id.mailbox = None # See DistinguishedFolderId.clean()

@property
def _folders_map(self):
# Top-level public folders may point to the root folder of the owning account and not the public folders root
# of this account. This breaks the assumption of get_children(). Fix it by overwriting the parent folder.
fix_parents = self._subfolders is None
res = super()._folders_map
if fix_parents:
with self._subfolders_lock:
for f in res.values():
if f.id != self.id:
f.parent = self
return res

def get_children(self, folder):
# EWS does not allow deep traversal of public folders, so self._folders_map will only populate the top-level
# subfolders. To traverse public folders at arbitrary depth, we need to get child folders on demand.
Expand Down

0 comments on commit 3c13440

Please sign in to comment.