fix: Ensure that all other distinguished folders than PublicFoldersRo…

…ot specify their account mailbox

exchangelib/folders/base.py

@@ -94,6 +94,8 @@ def __init__(self, **kwargs):
         self.item_sync_state = kwargs.pop("item_sync_state", None)
         self.folder_sync_state = kwargs.pop("folder_sync_state", None)
         super().__init__(**kwargs)
+        if self._distinguished_id and self.account:
+            self._distinguished_id.mailbox = Mailbox(email_address=self.account.primary_smtp_address)
 
     @property
     @abc.abstractmethod

exchangelib/folders/roots.py

@@ -327,6 +327,11 @@ class PublicFoldersRoot(RootOfHierarchy):
     DEFAULT_FOLDER_TRAVERSAL_DEPTH = SHALLOW
     supported_from = EXCHANGE_2007_SP1
 
+    def __init__(self, **kwargs):
+        super().__init__(**kwargs)
+        if self._distinguished_id:
+            self._distinguished_id.mailbox = None  # See DistinguishedFolderId.clean()
+
     def get_children(self, folder):
         # EWS does not allow deep traversal of public folders, so self._folders_map will only populate the top-level
         # subfolders. To traverse public folders at arbitrary depth, we need to get child folders on demand.

exchangelib/properties.py

@@ -762,6 +762,8 @@ def clean(self, version=None):
         if self.id == PublicFoldersRoot.DISTINGUISHED_FOLDER_ID:
             # Avoid "ErrorInvalidOperation: It is not valid to specify a mailbox with the public folder root" from EWS
             self.mailbox = None
+        elif not self.mailbox:
+            raise ValueError(f"DistinguishedFolderId {self.id} must have a mailbox")
 
 
 class TimeWindow(EWSElement):