Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asia/Kolkata timezone #187

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Add Asia/Kolkata timezone #187

merged 1 commit into from
Aug 4, 2017

Conversation

srinivasreddy
Copy link
Contributor

Pytz does not have Asia/Calcutta, it has Asia/Kolkata ; Kept Asia/Calcutta for backward compatibility

@ecederstrand
Copy link
Owner

Thanks for the PR!

The PYTZ_TO_MS_TIMEZONE_MAP name was badly chosen. CLDR_TO_MS_TIMEZONE_MAP would be better. The dict will be regenerated from time to time from the CLDR database using the generate_map() function, so your addition could get lost in the next update. I think it's better to keep extensions like this separately. Something like this:

PYTZ_TO_MS_TIMEZONE_MAP = {...}

# Add some timezone names used by pytz but not found in the CLDR
PYTZ_TO_MS_TIMEZONE_MAP.update({
    'Asia/Kolkata': 'India Standard Time',
})

Pytz does not have Asia/Calcutta, it has Asia/Kolkata ; Kept Asia/Calcutta for backward compatibility
@srinivasreddy
Copy link
Contributor Author

Done.

@ecederstrand ecederstrand merged commit 50669d7 into ecederstrand:master Aug 4, 2017
@ecederstrand
Copy link
Owner

Thanks for the contribution!

@srinivasreddy srinivasreddy deleted the patch-1 branch August 4, 2017 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants