Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/biometric unlock #2387

Merged
merged 11 commits into from Jul 28, 2022
Merged

Nt/biometric unlock #2387

merged 11 commits into from Jul 28, 2022

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Jul 26, 2022

What does this PR?

App now support unlocking using biometric... fully tested on ios, partially tested on android, will be testing on android shortly.

Update: tested on android as well

  • Setting new pin or changing ping ignores biometric and requires old pin input.
  • All other processes requires biometric if enabled and enrolled

Issue number

https://github.com/orgs/ecency/projects/2#card-83764380

Screenshots/Video

Screen.Recording.2022-07-26.at.4.17.30.PM.mov

@noumantahir noumantahir requested a review from feruzm July 26, 2022 11:23
@noumantahir noumantahir changed the title WIP - Nt/biometric unlock Nt/biometric unlock Jul 26, 2022
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, only would be better if we could offer unlock same way as pin, not after pin

@feruzm feruzm merged commit 3d87a0e into development Jul 28, 2022
@feruzm feruzm deleted the nt/biometric-unlock branch July 28, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants