Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Nt/auto login #2400

Merged
merged 15 commits into from Sep 15, 2022
Merged

[WIP] Nt/auto login #2400

merged 15 commits into from Sep 15, 2022

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Jul 28, 2022

What does this PR?

Status: It complete from implementation side, only marked it as WIP till backend side is ready for testing.

Now using same url structure for auto-login as returned by hive signer in web
Integrated with both deep link and QR based, videos attached

Web TODO: web will update to update apple_app_site_association file to support path /auth

url structure:
https://ecency.com/auth?code=[ACCESS_TOKEN]&username=[USERNAME]

sample url:
https://ecency.com/auth?code=eyJzaWduZWRfbWVzc2FnZSI6eyJ0eXBlIjoiY29kZSIsImFwcCI6ImVjZW5jeS5hcHAifSwiYXV0aG9ycyI6WyJkZW1vLmNvbSJdLCJ0aW1lc3RhbXAiOjE2NjA4MDMzOTUsInNpZ25hdHVyZXMiOlsiMWY3NzY2MTE5NTkyYTU4MDFhYzRhZTViOTdiM2UwYjdlNGVjNTIyOTE4MjM5NDVlNTVjYTI0NGI5ZmIxYzA4NGM0NmQwMGNlOGMyOTg2MmQ4YzMzMzI4Y2Y2NzljOTQzNzQ0MWQwOWJlMjI5ZmY4OWI4YzMyMmE5MDA1MmI3ZjExZSJdfQ..&username=demo.com

Issue number

https://github.com/orgs/ecency/projects/2#card-83929115

Screenshots/Video

video-1660820903.mp4
video-1660820458.mp4

@noumantahir noumantahir changed the title WIP - Nt/auto login [WIP] - Nt/auto login Aug 18, 2022
@noumantahir noumantahir changed the title [WIP] - Nt/auto login Nt/auto login Aug 18, 2022
@noumantahir noumantahir changed the title Nt/auto login [WIP] Nt/auto login Aug 18, 2022
@noumantahir
Copy link
Collaborator Author

@feruzm updated and tested access expiration

@feruzm
Copy link
Member

feruzm commented Sep 5, 2022

@noumantahir do we merge this before #2417 PR ? Also recent website update if access token expired, will ask to login. apple_app_site_association update still pending.

# Conflicts:
#	src/config/locales/en-US.json
#	src/screens/application/container/applicationContainer.tsx
src/screens/login/container/loginContainer.tsx Outdated Show resolved Hide resolved
src/screens/login/container/loginContainer.tsx Outdated Show resolved Hide resolved
@feruzm feruzm merged commit fc3d3c4 into development Sep 15, 2022
@feruzm feruzm deleted the nt/auto-login branch September 15, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants