New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Nt/auto login #2400
Merged
Merged
[WIP] Nt/auto login #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # android/app/src/main/AndroidManifest.xml # src/screens/application/container/applicationContainer.tsx
@feruzm updated and tested access expiration |
@noumantahir do we merge this before #2417 PR ? Also recent website update if access token expired, will ask to login. |
# Conflicts: # src/config/locales/en-US.json # src/screens/application/container/applicationContainer.tsx
feruzm
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
Status: It complete from implementation side, only marked it as WIP till backend side is ready for testing.
Now using same url structure for auto-login as returned by hive signer in web
Integrated with both deep link and QR based, videos attached
Web TODO: web will update to update apple_app_site_association file to support path
/auth
url structure:
https://ecency.com/auth?code=[ACCESS_TOKEN]&username=[USERNAME]
sample url:
https://ecency.com/auth?code=eyJzaWduZWRfbWVzc2FnZSI6eyJ0eXBlIjoiY29kZSIsImFwcCI6ImVjZW5jeS5hcHAifSwiYXV0aG9ycyI6WyJkZW1vLmNvbSJdLCJ0aW1lc3RhbXAiOjE2NjA4MDMzOTUsInNpZ25hdHVyZXMiOlsiMWY3NzY2MTE5NTkyYTU4MDFhYzRhZTViOTdiM2UwYjdlNGVjNTIyOTE4MjM5NDVlNTVjYTI0NGI5ZmIxYzA4NGM0NmQwMGNlOGMyOTg2MmQ4YzMzMzI4Y2Y2NzljOTQzNzQ0MWQwOWJlMjI5ZmY4OWI4YzMyMmE5MDA1MmI3ZjExZSJdfQ..&username=demo.com
Issue number
https://github.com/orgs/ecency/projects/2#card-83929115
Screenshots/Video
video-1660820903.mp4
video-1660820458.mp4