cleanup community container #2406
Conversation
| setNoResult(true); | ||
| } | ||
| }); | ||
| if (subscribedCommunities.data && subscribedCommunities.data.length) { |
There was a problem hiding this comment.
apparently this section is not considering subscribedCommunitiesCache as done is communityContainer, perhaps it can also use similar approach...
Check how Gaming Hive group is actually joined but search is still showing option to join communities while is should be showing leave, I did try refreshing the list but since data it is not yet updated in subscribedCommunities store and only available in subscribedCommunitiesCache which is not being considered here.
https://user-images.githubusercontent.com/6298342/182150778-ed235f21-c0af-41b8-ba65-7db754904d58.mov
|
@noumantahir actually cache wasn't implemented in communities results screen. |
There was a problem hiding this comment.
something if off in cache when you join community from various pages, for instance in screen shot with mobile screen included, check how community name is missing, that community was joined from search result page, redux cache store wise, same data comes out when we join community from community-profile screen
|
@noumantahir I am unable to reproduce this error. Can u please record a video for it. Here u can see in screenshots, community joined from search result page has correct data and showing in community list in editor |
|
sure, let me do try to do it... |
There was a problem hiding this comment.
@aliseyalvi odd, I was not able to reproduce it again, but it did happen once, I will add to blocked section of project board until we are able to find out why it happened in the first place.
I did face another issue though while testing, adding to backlog. For now we can approve and close this PR
What does this PR?
Removed extra/unnecessary usage of getSubscriptions api call in multiple components and replaced with data already saved in redux.
Issue number
fixes #2385