New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Allow QR based points purchase #2423
Conversation
screencast.2022-08-13.20-28-32.mp4 |
@@ -114,9 +114,9 @@ const HeaderView = ({ | |||
<IconButton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prop that enables qr button has misleading meaning... check here,
{enableViewModeToggle && ( |
src/config/locales/en-US.json
Outdated
@@ -248,7 +249,8 @@ | |||
}, | |||
"feedback_success": "Email successfully open", | |||
"feedback_fail": "Email client could not open", | |||
"server_fail": "Server not available" | |||
"server_fail": "Server not available", | |||
"show_imgs": "Show images" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps it should be Show Images
with (i) capital... most apps use text this way in settings...
@@ -0,0 +1,5 @@ | |||
const SHOW_HIDE_IMGS = 'show_hide_images'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I link this approach, may be we can add a TODO
comment to port more settings types here later.
src/config/locales/en-US.json
Outdated
@@ -131,7 +131,8 @@ | |||
"open_orders":"Open Orders", | |||
"conversions_requested":"Conversions Requested", | |||
"expires":"expires", | |||
"pending_requests":"Pending Requests" | |||
"pending_requests":"Pending Requests", | |||
"boost_account": "Boost" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@aliseyalvi @noumantahir yes, actually I would just add another ribbon into Points purchase page with username and avatar.
Or show same style avatar username like Account boost but on top of the list if username props exist (from QR scan) otherwise if accessed from app directly, we don't need to show avatar+username. |
@aliseyalvi @feruzm This what I am referring to, also quick to implement |
…into sa/qr-purchase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR?
This PR is WIP.
showActionModal
with header content showing username and avatar to whom points will be awarded... also add a confirmation body that include username of that user as well.dispatch(showActionModal(actionModalData))
Issue number
fixes #2401
Screenshots/Video
screencast.2022-08-12.20-46-19.mp4