Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Allow QR based points purchase #2423

Merged
merged 24 commits into from Aug 16, 2022
Merged

[WIP] Allow QR based points purchase #2423

merged 24 commits into from Aug 16, 2022

Conversation

aliseyalvi
Copy link
Collaborator

@aliseyalvi aliseyalvi commented Aug 12, 2022

What does this PR?

This PR is WIP.

  • Remove Buying points options from HIVE and HBD, we will only be offering buying points with in-app purchase.
  • Move QR option just beside search in home screen. and move show/hide images to settings
  • QR support for https://ecency.com/purchase?type=points&username=demo and https://ecency.com/purchase?type=points&username=demo&product_id=099points
  • In case of qr based purchase, you can use showActionModal with header content showing username and avatar to whom points will be awarded... also add a confirmation body that include username of that user as well.
  • Points screen should also show username to whom this points will be awarded to... just like we do in boost screen, show same style avatar username like Account boost but on top of the list dispatch(showActionModal(actionModalData))

Issue number

fixes #2401

Screenshots/Video

screencast.2022-08-12.20-46-19.mp4

@aliseyalvi
Copy link
Collaborator Author

screencast.2022-08-13.20-28-32.mp4

@@ -114,9 +114,9 @@ const HeaderView = ({
<IconButton
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prop that enables qr button has misleading meaning... check here,

{enableViewModeToggle && (

@@ -248,7 +249,8 @@
},
"feedback_success": "Email successfully open",
"feedback_fail": "Email client could not open",
"server_fail": "Server not available"
"server_fail": "Server not available",
"show_imgs": "Show images"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it should be Show Images with (i) capital... most apps use text this way in settings...

@@ -0,0 +1,5 @@
const SHOW_HIDE_IMGS = 'show_hide_images';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I link this approach, may be we can add a TODO comment to port more settings types here later.

@@ -131,7 +131,8 @@
"open_orders":"Open Orders",
"conversions_requested":"Conversions Requested",
"expires":"expires",
"pending_requests":"Pending Requests"
"pending_requests":"Pending Requests",
"boost_account": "Boost"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI does not seem just here.... perhaps make Boost all caps like GET POINTS it can even be GET BOOST, asking feruz in group as well.... verified by feruz
Screenshot 2022-08-15 at 12 36 14 PM

@noumantahir
Copy link
Collaborator

noumantahir commented Aug 15, 2022

@aliseyalvi

  • Points screen should also show username to whom this points will be awarded to... just like we do in boost screen.

Screenshot 2022-08-15 at 1 10 15 PM
Screenshot 2022-08-15 at 1 15 43 PM

@feruzm
Copy link
Member

feruzm commented Aug 15, 2022

@aliseyalvi @noumantahir yes, actually I would just add another ribbon into Points purchase page with username and avatar.

Best deals
Popular
(avatar) username

Or show same style avatar username like Account boost but on top of the list if username props exist (from QR scan) otherwise if accessed from app directly, we don't need to show avatar+username.

@noumantahir
Copy link
Collaborator

noumantahir commented Aug 15, 2022

Or show same style avatar username like Account boost but on top of the list

@aliseyalvi @feruzm This what I am referring to, also quick to implement

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now....

  • minor UI fine tune from my side

Screenshot 2022-08-16 at 11 08 56 PM

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit c321a27 into development Aug 16, 2022
@feruzm feruzm deleted the sa/qr-purchase branch August 16, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow QR based points purchase
3 participants