Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Beneficiaries not showing correctly #2425

Merged
merged 5 commits into from Aug 17, 2022
Merged

Conversation

aliseyalvi
Copy link
Collaborator

@aliseyalvi aliseyalvi commented Aug 17, 2022

What does this PR?

Filtered the default beneficiary from beneficiaries list while saving draft and saving beneficiaries list in redux.
Add default beneficiary when draft is loaded
This removes the inconsistancy caused by draft saved in ecency web as in ececny web it does not saves the default beneficiary but on mobile it was saving default beneficiary in meta. That was causing inconsistancy.

Issue Number

https://discord.com/channels/@me/920267778190086205/1009051563953758238

@aliseyalvi
Copy link
Collaborator Author

When we set schedule date on ececny web it saves schedule successfully but when we fetch it on ececny mobile it doesn't return schedule data in meta. It should be fixed on backend to work on ecency mobile . Refer screenshots
image
image
image

@noumantahir
Copy link
Collaborator

apparently adding schedule date in post settings, hide the ability to save draft... check Update Draft button is hidden
Screenshot 2022-08-17 at 1 27 53 PM

@aliseyalvi
Copy link
Collaborator Author

aliseyalvi commented Aug 17, 2022

Removed schedule info from meta and other code related to it which was done in some past PR

Refer commits:
0c6c7d0
a23b167
05eeda6

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 8a8a41f into development Aug 17, 2022
@feruzm feruzm deleted the sa/beneficiaries-bug branch August 17, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants