Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] working on mute/unmute in feed #2434

Merged
merged 4 commits into from Aug 28, 2022
Merged

Conversation

aliseyalvi
Copy link
Collaborator

What does this PR?

Issue number

Screenshots/Video


};

_handleFollowUnfollowUser = async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliseyalvi do we really need this considering, I think we can just keep feed limited to blocking. user my unblock later from profile, also we can give option somewhere in profile to view a list of blocked users and unblock them if required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if post is showing in screen but content is hidden, it would be easy for user to unblock again. But we can remove that , what u suggest

currentAccount.mutes = [username, ...curMutes];
}
dispatch(updateCurrentAccount(currentAccount));
onLoadPosts(true); //fetch posts again after muting user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of passing this prop from grad parent, perhaps better option would to hive content on feed, I think there is an option for that... the card can keep tracked of muted blocked users from currentAccount and hide content using that instead passing a prop deep inside.

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, I believe

  1. we do not need to pass onLoadPosts to grant parents and can user currentAccount data change event to hide content.
  2. Perhaps we can limit dropdown option to Block only, no need to unblocking option in feed screen

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to handle logged out state. Other than that I think it's working perfectly

Screenshot 2022-08-27 at 12 23 53 PM

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@feruzm feruzm merged commit 9766a7a into development Aug 28, 2022
@feruzm feruzm deleted the sa/mute-unmute-feed branch August 28, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants