Nt/media insertion #2448
Merged
Nt/media insertion #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/screens/editor/container/editorContainer.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
The feature for adding image directly in content before uploaded finishes was very tricky to implement with out
setNativePropseditor flow as it was causing some glitches when uploads finishes while user is writing content. Most of time is consumed to add a logic to avoid such glitches and it has to be tested well.Issue number
#2430
Screenshots/Video
Screen.Recording.2022-09-08.at.4.21.05.PM.mov
Screen.Recording.2022-09-08.at.4.21.46.PM.mov