Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/post display optimise #2591

Merged
merged 44 commits into from Feb 7, 2023
Merged

Nt/post display optimise #2591

merged 44 commits into from Feb 7, 2023

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Jan 19, 2023 •
edited

What does this PR?

  • restructured comment cache management
  • using react query and redux to unify comment/discussion fetch
  • using single FlatList to render post, comment and replies efficiently

Pending:
inject local cache,

Where should the reviewer start?

Steps to reproduce

Issue number

fixes #2614

Screenshots/Video

Over all demo
https://user-images.githubusercontent.com/6298342/216063131-d4e26fa8-57c5-4458-ae50-ee9a6c272c1e.mov

New comment shows on top
https://user-images.githubusercontent.com/6298342/216063296-6f6c307b-70e9-476c-a3c0-04dfc9af8ae0.mov

comment update test
https://user-images.githubusercontent.com/6298342/216063348-94f49007-36d4-4066-b5a1-95068cf7d33c.mov

@noumantahir
refactored commentsDisplay to postComments
4d2a731
@noumantahir
rendering comments as single list
938a04c
@noumantahir
restructured discussion data processing
c3b31bf
@noumantahir
rendering all comments and replies for now
719fb69
@noumantahir
clean up implementation uptill basic reply rendering
42430f1
@noumantahir
readded basic animation
afe30a9
@noumantahir
lint
faf32e6
@noumantahir
Merge branch 'development' into nt/post-display-optimise
3498cd8 
# Conflicts:
#	src/providers/queries/postQueries/postQueries.ts
#	src/screens/post/container/postContainer.tsx
@noumantahir
Merge remote-tracking branch 'upstream/development' into nt/post-disp…
1458bd5 
…lay-optimise
@noumantahir
fixed some of revert caused issue
7ec1017
@noumantahir
put back reverted methods
2d77e9c
@noumantahir
import fix
b3f8a1c
@noumantahir
Merge remote-tracking branch 'upstream/development' into nt/post-disp…
3ce919e 
…lay-optimise
@noumantahir
changed comments map to collection
1110ef2
@noumantahir
return parent post in discussion response
bae85eb
@noumantahir
successfully injecting first level cache
2d4a732
@noumantahir
Merge remote-tracking branch 'upstream/development' into nt/post-disp…
33524d1 
…lay-optimise
@noumantahir
updated comment cache paths
1a1a0f5
@noumantahir
using childCount and replies directly from comment prop
049da8d
@noumantahir
fixed children typo
22e39e6
@noumantahir
setting auto reveal flag
8d4effa
@noumantahir
Merge branch 'development' into nt/post-display-optimise
dcca127
@noumantahir
made comments loading faster and smoothened reveal animations
4a341d3
@noumantahir
introduced CommentsSction helper component
eb37220
@noumantahir noumantahir changed the title [WIP] Nt/post display optimise Nt/post display optimise Feb 1, 2023
feruzm
feruzm approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit e3a4626 into development Feb 7, 2023
@feruzm feruzm deleted the nt/post-display-optimise branch February 7, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise Post Display : Phase 2
2 participants
@noumantahir @feruzm