Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/editor fixes #2602

Merged
merged 4 commits into from Jan 24, 2023
Merged

Nt/editor fixes #2602

merged 4 commits into from Jan 24, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

  • fixed empty tag issues
  • using reference body text and selection
  • removed username search to test editor crash
  • fixed rendering issues related to editor community selector

Screenshots/Video

Screen.Recording.2023-01-24.at.3.09.29.PM.mov
Screen.Recording.2023-01-24.at.3.09.58.PM.mov

feruzm
feruzm approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good call on username search, might have been issue if servers timeout or has issues while typing.

@feruzm feruzm merged commit 6937426 into development Jan 24, 2023
@feruzm feruzm deleted the nt/editor-fixes branch January 24, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noumantahir @feruzm