Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/boost fixes #2605

Merged
merged 3 commits into from Jan 24, 2023
Merged

Nt/boost fixes #2605

merged 3 commits into from Jan 24, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

I was not able recreate the issue faced by user, but the first step I took ideally fix the issue as this is the only differentiating factor I could find that could lead to an issue if all keys are preset as expected.

  • comparing user using username instead of name, as username is separator in selection dropdown as well
  • using selected account local data from otherAccounts instead of realm
  • improved error messaging toast
  • added bugsang to a few relevant places in dhive.js

@@ -1732,11 +1741,15 @@ export const transferPoint = (currentAccount, pinCode, data) => {
};
const opArray = [['custom_json', op]];
return sendHiveOperations(opArray, privateKey);
} else {
const err = new Error('Check private key permission! Required private active key or above.')
Copy link
Member

@feruzm feruzm Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

custom_json generally doesn't require active key, posting key is also acceptable except engine token or point ops. So this error might be related to if custom_json operation using posting_auths or auths field.

Oh sorry, it is point transfer function, so all good!

Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 982b6b1 into development Jan 24, 2023
@feruzm feruzm deleted the nt/boost-fixes branch January 24, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants