Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/flatlist optimise #2639

Merged
merged 2 commits into from Mar 12, 2023
Merged

Nt/flatlist optimise #2639

merged 2 commits into from Mar 12, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

Optimised and tested feed and comments flatlists.

  • Reduced rendering load to roughly half while processing post comments.
  • On some ios devices (iPhone X) often times some of feed list items were being unresponsive, issue seems to have been fixed by removing prop removeClippedSubview though tested well afterwards yet need more testing after TestFlight versions is available.

Issue number

https://github.com/orgs/ecency/projects/2#card-87963367

@noumantahir noumantahir requested a review from feruzm March 12, 2023 08:28
feruzm
feruzm approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@feruzm feruzm merged commit 8fce18c into development Mar 12, 2023
@feruzm feruzm deleted the nt/flatlist-optimise branch March 12, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noumantahir @feruzm