Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/img cache optimise #2641

Merged
merged 3 commits into from Mar 12, 2023
Merged

Nt/img cache optimise #2641

merged 3 commits into from Mar 12, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

  • clears image memory on memoryWarning generated, will handle warnings made if feed cache goes beyond limits
  • clears image memory coming back from post screen, handles instant memory clearing when post screen unmount, apparently this does not affected images already displayed on screen and re-rendering of posts picks image from disk cache.

@noumantahir noumantahir requested a review from feruzm March 12, 2023 19:16
feruzm
feruzm approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit be02d36 into development Mar 12, 2023
@feruzm feruzm deleted the nt/img-cache-optimise branch March 12, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noumantahir @feruzm