Mb/api migration #2723
Merged
Mb/api migration #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noumantahir
reviewed
Jul 21, 2023
src/providers/ecency/ePoint.ts
Outdated
| export const gameStatusCheck = async (game_type: string) => { | ||
| try { | ||
| const data = { game_type }; | ||
| const res = await ecencyApi.post('/private-api/get-game', data); |
There was a problem hiding this comment.
data object is being sent as post request body here since request if of type POST, you can either merge params with url path or add them in config as params, that is usually third argument of an axios post method.
noumantahir
reviewed
Jul 21, 2023
src/providers/ecency/ePoint.ts
Outdated
| export const gameClaim = async (game_type: string) => { | ||
| try { | ||
| const data = { game_type }; | ||
| const res = await ecencyApi.post('/private-api/get-game', data); |
There was a problem hiding this comment.
same mistake here...{game_type} should be sent as params while {key} should the data passed body
noumantahir
reviewed
Jul 21, 2023
src/providers/ecency/ecency.ts
Outdated
| export const addReport = async (type: 'content' | 'user', data: string) => { | ||
| try { | ||
| const response = await api.post('/report', { | ||
| const response = await api.post('/private-api/report', { |
There was a problem hiding this comment.
use ecencyApi instead api
noumantahir
reviewed
Jul 21, 2023
src/providers/ecency/ecency.ts
Outdated
| * data:string | ||
| * | ||
| **/ | ||
| export const deleteAccount = async (data: string, username: string) => { |
There was a problem hiding this comment.
- username should be first argument to avoid conflict from previous calls
- use
ecencyApiinsteadapi
noumantahir
reviewed
Jul 21, 2023
src/providers/ecency/ecency.ts
Outdated
| // .catch((error) => bugsnagInstance.notify(error)); | ||
|
|
||
| export const purchaseOrder = async (data: PurchaseRequestData, platform: string, product: string, receipt: string, user: string) => { | ||
| const orderData = { |
There was a problem hiding this comment.
- there is no source to initialise this object,
datais never used here. - request properties is already a part of
datapassed to method
noumantahir
approved these changes
Jan 29, 2024
This reverts commit af1552f.
feruzm
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
End points that need to migration
Where should the reviewer start?
Steps to reproduce
Issue number
#2723
Screenshots/Video