Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GU-2745 add repeat transfer support for other tokens #2790

Merged
merged 7 commits into from
May 15, 2024
Merged

feat: GU-2745 add repeat transfer support for other tokens #2790

merged 7 commits into from
May 15, 2024

Conversation

gamingumar
Copy link
Collaborator

No description provided.

@gamingumar gamingumar mentioned this pull request Nov 13, 2023
Open
2 tasks
noumantahir
noumantahir requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@noumantahir noumantahir left a comment •
edited by gamingumar
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transfer working good for HBD and Engine token... one code suggestion in comments and some issues I detected are...

  • Ecency Points transfer not working as expected, leads to boost screen in my testing. screenshot 1 and 2
  • Repeat icon appearing on all activity items, that is only required for transfer operation specifically. screenshot 3
  • HP need to repeat at all, since it's nothing but staked HIVE. screenshot 4

Screenshot 1
Screenshot 2023-11-13 at 19 57 16

Screenshot 2
Screenshot 2023-11-13 at 20 05 49

Screenshot 3
Screenshot 2023-11-13 at 19 56 32

Screenshot 4
Screenshot 2023-11-13 at 19 57 43

src/screens/assetDetails/screen/assetDetailsScreen.tsx Outdated Show resolved Hide resolved
@gamingumar
Copy link
Collaborator Author

@noumantahir please test now, fixed support of points

@gamingumar gamingumar self-assigned this Dec 5, 2023
@noumantahir
Merge branch 'development' into feat/GU-2745/repeat-transfer-others
e8402c6 
# Conflicts:
#	ios/Podfile.lock
#	src/screens/editor/container/editorContainer.tsx
@noumantahir
introduced repeatable transaction activity property, set based on rep…
f8222b4 
…eatable transfers list
@noumantahir
Copy link
Collaborator

UPDATE
instead of using string based operation to decide which operation support repeating, added privilege list of transactions that would support repeating, later this list can be updated to support further operations like swap repeat etc.

Screen.Recording.2024-05-15.at.17.55.32.mov

@noumantahir noumantahir self-assigned this May 15, 2024
@noumantahir noumantahir removed their request for review May 15, 2024 12:59
feruzm
feruzm approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit fa1707d into development May 15, 2024
@feruzm feruzm deleted the feat/GU-2745/repeat-transfer-others branch May 15, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noumantahir noumantahir noumantahir requested changes

@feruzm feruzm feruzm approved these changes

Assignees

@gamingumar gamingumar

@noumantahir noumantahir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gamingumar @noumantahir @feruzm