Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] repositioned promoted text #2804

Merged
merged 2 commits into from Dec 18, 2023
Merged

Conversation

aliseyalvi
Copy link
Collaborator

@aliseyalvi aliseyalvi commented Dec 18, 2023

What does this PR?

This PR repositions the promoted text above post title instead of infront of post time

Issue number

fixes #2803

Screenshots/Video

image

fontSize: 14,
fontWeight: '300',
color: '$primaryDarkGray',
marginTop: 6,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be try adding negative bottom margin/padding here to make upper and lower spacing more fine tuned
Screenshot 2023-12-18 at 15 38 19

@aliseyalvi
Copy link
Collaborator Author

added negative margin to the promoted text

image

Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit aca54b6 into development Dec 18, 2023
@feruzm feruzm deleted the sa/reposition-promoted-text branch December 18, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reposition promoted text to show post time at default place in post card.
3 participants