Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate external url polyfill #2854

Merged
merged 1 commit into from
Mar 30, 2024
Merged

integrate external url polyfill #2854

merged 1 commit into from
Mar 30, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

Apparently react-native have dropped support for URL polyfill that stared producing url parsing related issues both in deep link and html post links.

Integrating external polyfill package fixed the issue

Issue number

https://discord.com/channels/@me/920267778190086205/1215513512672100362
https://discord.com/channels/@me/920267778190086205/1222883542401286216

Screenshots/Video

https://github.com/ecency/ecency-mobile/assets/6298342/3c8f60c9-d744-4f89-92f6-747ddf429974
https://github.com/ecency/ecency-mobile/assets/6298342/e5578d94-9c01-4054-8518-99978150eaac

@noumantahir noumantahir requested a review from feruzm March 29, 2024 21:41
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@feruzm feruzm merged commit 2553c31 into development Mar 30, 2024
@feruzm feruzm deleted the nt/url-parser branch March 30, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants