Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safearea padding issue in profile edit screen #2855

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

aliseyalvi
Copy link
Collaborator

@aliseyalvi aliseyalvi commented Apr 14, 2024

What does this PR?

  • added SafeAreaView in header of profile edit screen
  • added close button to close the edit screen

Issue number

https://discord.com/channels/@me/920267778190086205/1226358315672408175

Screenshots/Video

Screenshot_2024-04-14-10-26-55-175_app esteem mobile android

* added safeareaview in header of profile edit screen
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 81889c6 into development Apr 14, 2024
@feruzm feruzm deleted the sa/improve-profile-edit-screen branch April 14, 2024 06:16
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliseyalvi why introduce new component, shouldn't <BasicHeader/> be enough...?

@aliseyalvi
Copy link
Collaborator Author

@aliseyalvi why introduce new component, shouldn't <BasicHeader/> be enough...?

was it there? I didn't knew it is there. if it is there I'll update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants