Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows center alignment for Mini.Files #382

Closed
2 tasks done
wroyca opened this issue Jun 23, 2023 · 8 comments
Closed
2 tasks done

Allows center alignment for Mini.Files #382

wroyca opened this issue Jun 23, 2023 · 8 comments
Labels

Comments

@wroyca
Copy link
Contributor

wroyca commented Jun 23, 2023

Contributing guidelines

Module(s)

Mini.Files

Description

In Zen mode, it would be beneficial to have center alignment layout for Mini.Files - and, similarly, it would also be useful when the terminal width is smaller, such as GNOME Terminal default 80x24:

image

image

@wroyca wroyca added the feature-request Feature request label Jun 23, 2023
@echasnovski
Copy link
Owner

Thanks for suggestion!

Unfortunately, this will result into a lot of extra code, which is not good.

Also having it always in top-left ensures maximum space to show both directory contents and branch depth.

Closing as not planned.

@wroyca
Copy link
Contributor Author

wroyca commented Jun 23, 2023

Thanks for suggestion!

Unfortunately, this will result into a lot of extra code, which is not good.

Also having it always in top-left ensures maximum space to show both directory contents and branch depth.

Closing as not planned.

@echasnovski Just a thought, achieving the same result is feasible by setting windows.max_number to 1 and making minor tweaks to row and column. For individuals who are not concerned about depth, could there be a possibility of offering it as a configurable option when max_number = 1 ?

image

@echasnovski
Copy link
Owner

@echasnovski Just a thought, achieving the same result is feasible by setting windows.max_number to 1 and making minor tweaks to row and column. For individuals who are not concerned about depth, could there be a possibility of offering it as a configurable option when max_number = 1 ?

I am highly against it now, but will be keeping this in mind.

@idelice
Copy link

idelice commented Apr 29, 2024

+1

@echasnovski you have "kept this in mind" for 10~ months now.

Any plan on adding this feature that enables consumers to modify the position?

@echasnovski
Copy link
Owner

FYI, what "will be keeping this in mind" referred to was allowing config tweaks for the single window.

No, I am still against it for the reasons stated in this comment.

@idelice
Copy link

idelice commented Apr 29, 2024

FYI, what "will be keeping this in mind" referred to was allowing config tweaks for the single window.

No, I am still against it for the reasons stated in this comment.

Ok, that's too bad.

@wroyca
Copy link
Contributor Author

wroyca commented Apr 29, 2024

FYI, what "will be keeping this in mind" referred to was allowing config tweaks for the single window.

No, I am still against it for the reasons stated in this comment.

Are you still against it for the single window? I find myself running a tiny fork locally to adjuste the position a little ( adding just slightly more padding/margin in the top left for example ) :)

Fyi I don't mind submitting PR for this 🫡

@echasnovski
Copy link
Owner

Are you still against it for the single window?

Yes. Supporting adjustment only for a rather small subset of (not really primary) usages doesn't look like hitting the right "maintainability-features" balance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants