Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert muon #97

Merged
merged 10 commits into from
Dec 18, 2022
Merged

Revert muon #97

merged 10 commits into from
Dec 18, 2022

Conversation

apprehensions
Copy link
Contributor

this PR will revert all the changes for muon following the fact that no matter what, until illiliti solves it, meson will always still be needed.

this will remove the need for muon at build time, as muon has still not been up-streamed in the KISS repositories yet.

also fixes some packages.

@ehawkvu , yajl is broken and i3 is broken and this is untested.
i will also ask you to put the current kiss-xorg branch into muon branch for the muon changes to be kept, my PR #86 should be merged into that branch as well.

@apprehensions apprehensions mentioned this pull request Dec 2, 2022
29 tasks
@echawk
Copy link
Owner

echawk commented Dec 14, 2022

@wael444 Sorry it's taken so long to get to this PR. Are you saying that you'd like to just keep the other muon PR open so that once it's ready we can merge?

Also, I have added yajl to this repo so that should be fine now. Is it worthwhile to investigate bumping i3's version too?

@apprehensions
Copy link
Contributor Author

Are you saying that you'd like to just keep the other muon PR open so that once it's ready we can merge?

Yes. It isn't worthwhile to have a repository use a different build system as to the mainline repositories. One will still need meson for mesa and some packages, so why is it worth it to use meson when it can just be removed thanks to kiss orphans?

@echawk
Copy link
Owner

echawk commented Dec 15, 2022

That works for me -- also how do you feel about adding in pkg-config checks in a few of the packages under extra/ to check for wayland? And if you have xwayland installed (with sway forked to support it) you shouldn't have to rebuild much, if anything besides mesa.

@apprehensions
Copy link
Contributor Author

to check for wayland?

I do this myself in my own repositories, having a Xorg repository also have the ability to work with Wayland is weird. It should have some discussion IMO.

Maybe under its own repository called 'xwayland', literally meant for both to be in use of some sort.. Idk.

@echawk
Copy link
Owner

echawk commented Dec 18, 2022

Sounds good to me. I'll open an issue.

@echawk echawk merged commit c141427 into echawk:master Dec 18, 2022
@apprehensions apprehensions deleted the revert-muon branch April 2, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants