Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure required options are not empty #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

videni
Copy link

@videni videni commented Nov 15, 2016

since these options are required, I think it is necessary to make sure they are not empty.

since these options are required, I think it is necessary to make sure they are not empty.
@xjchengo
Copy link
Contributor

Thanks. From PHP manual:

The following things are considered to be empty:

"" (an empty string)
0 (0 as an integer)
0.0 (0 as a float)
"0" (0 as a string)
NULL
FALSE
array() (an empty array)
$var; (a variable declared, but without a value)

Some options may use above values, so we cannot restrict options not empty.
Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants