fix: Minor login improvements #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ute them to sign in
dennis-campos
changed the title
dennis-campos
commented
Jul 14, 2023
Comment on lines
-94
to
-95
| <NextLink href="/reset-password"> | ||
| <Button variant="link" size="sm"> |
There was a problem hiding this comment.
I don't think NextLink is necessary anymore. I'm also not seeing it in the "pages" docs
dennis-campos
commented
Jul 14, 2023
| <NextLink href="/reset-password"> | ||
| <Button variant="link" size="sm"> | ||
| <Link href="/reset-password"> | ||
| <Button variant="link" size="sm" type="button"> |
There was a problem hiding this comment.
If the user hits enter on their keyboard, it redirected them to /reset-password instead of signing in. The workaround is having type=button attribute. This is necessary when there are multiple buttons in a form.
dennis-campos
commented
Jul 14, 2023
| async function handleLogout() { | ||
| signOut(); | ||
| await router.replace('/login'); |
There was a problem hiding this comment.
This caused a flash to /login page and redirected the user back to /
kgajera
approved these changes
Aug 18, 2023
cullylarson
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/loginpage after signing out./reset-passwordwhen it should log you in.Checklist