Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix casting for GeoJSON #12

Merged
merged 1 commit into from
Aug 2, 2016
Merged

fix casting for GeoJSON #12

merged 1 commit into from
Aug 2, 2016

Conversation

vedi
Copy link
Contributor

@vedi vedi commented Aug 2, 2016

I use generic GeoJSON in my schema. The validation is always failed because of broken code. It's a way, how I fix this.

I'd appreciate if you merge PR or fix the bug ASAP, it will make me possible to start using this module.

@joshkopecek
Copy link
Contributor

@markstos @bendalton with a small alteration to the tests, this works well. I will merge.
@vedi can you detail how this wasn't working for you before?

@joshkopecek joshkopecek merged commit 3a8ece3 into echoes-xyz:master Aug 2, 2016
@vedi
Copy link
Contributor Author

vedi commented Aug 2, 2016

can you detail how this wasn't working for you before?

I put polygon there and got validatePolygonObject is not defined. I guess it would not work in the same way for other types as well.

@vedi
Copy link
Contributor Author

vedi commented Aug 2, 2016

and thank you for your quick response, looking forward to see new version in npm

@joshkopecek
Copy link
Contributor

Done. New version is up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants