Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging a selection box goes out-of-bounds when graph container is larger than graph #53

Closed
midrare opened this issue Dec 15, 2020 · 5 comments
Labels

Comments

@midrare
Copy link

midrare commented Dec 15, 2020

Platform: Windows 10 x64 build 19041
graph-editor version: commit 70a8567 from repo latest as of 2020/12/14
Tested Java versions: Adopt OpenJDK 15 and Amazon Coretto 11

Demo: https://streamable.com/d4hqeq
Demo code: https://pastebin.com/5kpBNn7d

Steps to reproduce:

  1. Instantiate a GModel, a GraphEditor, and a GraphEditorContainer. (Optional: enable minimap view)
  2. Resize the GraphEditorContainer so that it's larger than the GraphEditor
  3. Click and drag a selection box past the top-left boundaries of the graph
  4. Observe that the graph suddenly flickers to the right of the screen
  5. Observe that the minimap, if enabled, displays an impossible viewing rectangle--one that's out of the bounds of the graph itself

This bug also occurs if you zoom out too far using the minimap.

@eckig
Copy link
Owner

eckig commented Dec 15, 2020

Can confirm. I will look into this.

@eckig eckig added the bug label Dec 15, 2020
eckig added a commit that referenced this issue Dec 15, 2020
where the container is larger than the actual editor.
@eckig
Copy link
Owner

eckig commented Dec 15, 2020

I added a commit that should fix the selection box and minimap locator - can you verify that it is working for you?

@eckig eckig changed the title [BUG] Dragging a selection box goes out-of-bounds when graph container is larger than graph Dragging a selection box goes out-of-bounds when graph container is larger than graph Dec 15, 2020
@midrare
Copy link
Author

midrare commented Dec 15, 2020

Yes, I can verify both fixes are working. All that's left now is the graph jumping to the right of the screen.

eckig added a commit that referenced this issue Dec 16, 2020
@eckig
Copy link
Owner

eckig commented Dec 16, 2020

Yes, you are right. Should be resolved by now.

@midrare
Copy link
Author

midrare commented Dec 16, 2020

Yup, tested and issue is fixed.

@midrare midrare closed this as completed Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants