Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Probably needs a warning that limit and offset are blatted #1

Closed
antony opened this issue Sep 11, 2018 · 1 comment
Closed

Probably needs a warning that limit and offset are blatted #1

antony opened this issue Sep 11, 2018 · 1 comment

Comments

@antony
Copy link

antony commented Sep 11, 2018

Thanks for the plugin!

I think it would be really useful if using limit/offset caused a warning if set. The fact they are overridden without warning can cause some unpredictability for an end user.
lgaticaq pushed a commit that referenced this issue Sep 14, 2018
@semantic-release-bot
chore(release): 1.1.3 [skip ci]
426313d 
## [1.1.3](v1.1.2...v1.1.3) (2018-09-14)

### Bug Fixes

* **options:** add warning if provide limit or offset ([206a8ae](206a8ae)), closes [#1](#1)
@lgaticaq
Copy link
Member

Ready in v1.1.3 👍

lgaticaq pushed a commit that referenced this issue Mar 1, 2019
@vandaimer
Merge pull request #1 from vandaimer/group-by-statement
daa2256 
Group by statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antony @lgaticaq