Update to Java 21 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As part of this PR, I have also updated the project settings to explicitly specify Java 21 compliance. The project settings now also explicit;y set Xtend code generation to Java 17. This has to remain until eclipse/xtext#2686 is complete. |
Java 21 adds List.getLast(), which throws an exception if the list is empty. Xtend also has an extension method getLast(), which returned null. Since the Java 21 method is declared directly in List, it has precedence over the extension method, which changes the behavior of existing Xtend code. This change fixes the problematic cases where getLast is called in Xtend code.
azoitl
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.