Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed detaching of SubApp from Type with no open editor #324

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixed detaching of SubApp from Type with no open editor #324

wants to merge 1 commit into from
+14 −10

Conversation

sebHollersbacher
Copy link

@sebHollersbacher sebHollersbacher commented Jul 23, 2024 •
edited
Loading

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2024 •
edited
Loading

Test Results

    97 files  ±0      97 suites  ±0   39s ⏱️ -2s
27 173 tests ±0  27 173 ✅ ±0  0 💤 ±0  0 ❌ ±0 
27 174 runs  ±0  27 174 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ad5aecf. ± Comparison against base commit 668ed80.

♻️ This comment has been updated with latest results.

azoitl
azoitl requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@azoitl azoitl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear this fixes the wrong problem. It should not be allowed that the SubApp is detached from the type in the system explorer. Can please change that such that the handler is not active when the subapp is selected in the system explorer tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azoitl azoitl azoitl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebHollersbacher @azoitl