Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes AASXDeserializer getRelatedFiles crashes #229

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Fixes AASXDeserializer getRelatedFiles crashes #229

merged 4 commits into from
Jan 23, 2024

Conversation

FrankSchnicke
Copy link
Contributor

  • Only file URLs are tried to resolve
  • Non-existing files lead to a warning

Closes #227

@FrankSchnicke
Fixes AASXDeserializer getRelatedFiles crashes
3597022 
* Only file URLs are tried to resolve
* Non-existing files lead to a warning

Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
@twebermartins twebermartins added the V.1.0.0 Final Release V.1.0.0 following EF processes label Jan 16, 2024
@mjacoby mjacoby merged commit 8967ad8 into main Jan 23, 2024
4 checks passed
@mjacoby mjacoby deleted the bugfix/related-files branch January 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjacoby mjacoby Awaiting requested review from mjacoby

Assignees
No one assigned
Labels
V.1.0.0 Final Release V.1.0.0 following EF processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AASX containing Submodels with Files referencing files that are external to the AASX lead to a crash
3 participants
@FrankSchnicke @mjacoby @twebermartins