Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GitHub Issues 220 and 222 #223

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

juileetikekar
Copy link
Contributor

@juileetikekar juileetikekar commented Feb 21, 2024

Description

This PR includes fixes for GitHub Issues #220 and #222.

[a] If a V2 AASX file consists of a concept description with empty IsCaseOf reference, V3 conversion and thereby file APIs fail due to constraints in xml de/serializations from aas-core-sdk. Thus, if V1 or V2 AASX files have such empty IsCaseOf reference, there are skipped from the conversion.

[b] Additionally, the server was showing a few command line arguments (-h, -p, -rest, -https, -external-rest ), which are not supported anymore. Hence, with this PR such arguments are removed.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

[a] was successfully tested with GetAASXFile Api
[b] was tested with commandline execution of server with help option.

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@juileetikekar juileetikekar merged commit 29981ac into main Feb 22, 2024
4 of 5 checks passed
@juileetikekar juileetikekar deleted the jtikekar/GitHubIssues/220_222 branch March 25, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant