Delete startupState from CompleteState #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue-Id: #242
maturar
added
the
enhancement
Issue-Id: #242
* Move conditions to env variables * Comment out conditionals * Print github var * Print dedicated vars * Disable not needed steps and add env expressions * Print environment variable * Add conditional check with env vars * Remove if conditions from jobs * Add env var check to job * Revert to direct condition in job * Short job condition * Remove curly braces in if * Revert to direct condition * Add comment * Test removed rust-cache action * Add clippy code smell check * Test failing clippy cicd check * Revert clippy issue * Run clippy after build * Run clippy after build * Test split into separated jobs * Fix build issue for stests * Extract clippy check to own job * Disable clippy for dependencies * Save cash only on push on main * Rename job to test cache of main * Improve naming of gh actions build jobs * Put code checks to utests * Introduce tag for excluding stests on pr runs * Exclude tagged stests in ci cd * Fix condition * Fix conditional check * Fix invalid condition and naming * Fix tag and simplify condition * Revert condition * Pull stest command directly in condition * Add log for executing all stests * Activate all pipeline steps again
Issue-Id: #242
|
Note: the commit d621555 is only an attempt to merge |
|
There are still some places were we talk about the "startup state". I wonder if it wouldn't better to reword there to startup manifest. |
Issue-Id: #242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #242
Definition of Done
The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.