Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies to URL crate #296

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Remove dependencies to URL crate #296

merged 2 commits into from
Jun 19, 2024

Conversation

krucod3
Copy link
Contributor

@krucod3 krucod3 commented Jun 14, 2024

This PR removes the dependency to the URL crate as the functionality can be easily achieved also without pulling in 28 dependencies into Ankaios.

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

Copy link
Contributor

@maturar maturar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maturar maturar merged commit 2c769d6 into main Jun 19, 2024
10 checks passed
@maturar maturar deleted the remove_dependency_to_url branch June 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants