Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure merge queue for the main branch #3

Closed
mnonnenmacher opened this issue Mar 14, 2024 · 6 comments
Closed

Configure merge queue for the main branch #3

mnonnenmacher opened this issue Mar 14, 2024 · 6 comments

Comments

@mnonnenmacher
Copy link
Contributor

Please enable the merge queue as part of the branch protection rules for the main branch as this can currently not be done via Otterdog (see eclipse-csi/otterdog#86).

The required settings are:
Merge method: "Rebase and merge"
Maximum pull requests to build: 5
Minimum pull requests to merge: 1 or after 5 minutes
Maximum pull requests to merge: 5
Only merge non-failing pull requests: true
Consider check failed after: 60 minutes

@eclipse-apoapsis-bot
Copy link
Contributor

settings have been applied manually to the existing branch protection rule for branch main:

image

@mnonnenmacher
Copy link
Contributor Author

Thanks, looking good in my test PR eclipse-apoapsis/ort-server#1.

@mnonnenmacher
Copy link
Contributor Author

@netomi There is one issue with the merge queue that is caused by the global eclipsefdn/eca workflow. This workflow is required but not triggered by the merge queue, therefore it times out after a while (see eclipse-apoapsis/ort-server#2):

github-merge-queue bot removed this pull request from the merge queue due to no response for status checks

To solve this the merge_group event would have to be added as a trigger to the workflow:

on:
  merge_group:
    types: [checks_requested]

What would be the correct place to request such a change?

@mnonnenmacher mnonnenmacher reopened this Mar 19, 2024
@netomi
Copy link
Contributor

netomi commented Mar 19, 2024

So the eclipsefdn/eca status check is not handled via a workflow but through a GitHub App that reacts on webhook events.
We will need to request that here: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api

As a short term solution, we can remove the eclipsefdn/eca check from the list of required checks in the branch protection rule.
Change the line https://github.com/eclipse-apoapsis/.eclipsefdn/blob/main/otterdog/eclipse-apoapsis.jsonnet#L22

to

-          required_status_checks+: [
+          required_status_checks: [

so the eca check is not inherited from the default config.

@netomi
Copy link
Contributor

netomi commented Mar 19, 2024

@mnonnenmacher
Copy link
Contributor Author

Thanks for the explanation and creating the ticket. I will apply the workaround for now.

mnonnenmacher added a commit to mnonnenmacher/.eclipsefdn-apoapsis that referenced this issue Mar 20, 2024
Do not inherit from the default required status checks in the ort-server
repository. This effectively removes the `eclipsefdn/eca` check from the
list of required checks. The reason is that this check is currently not
triggered by the `merge_group` event and therefore the checks in the
merge queue time out which makes it impossible to merge any pull
requests. For details see [1].

The check can be made required again once [2] was implemented.

[1]: eclipse-apoapsis#3 (comment)
[2]: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/issues/161

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
eclipse-otterdog-app bot pushed a commit that referenced this issue Mar 20, 2024
Do not inherit from the default required status checks in the ort-server
repository. This effectively removes the `eclipsefdn/eca` check from the
list of required checks. The reason is that this check is currently not
triggered by the `merge_group` event and therefore the checks in the
merge queue time out which makes it impossible to merge any pull
requests. For details see [1].

The check can be made required again once [2] was implemented.

[1]: #3 (comment)
[2]: https://gitlab.eclipse.org/eclipsefdn/it/api/git-eca-rest-api/-/issues/161

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants