Include Java version on generating classes jar file to resolve UnsupportedClassVersion #155

annaibm · 2024-06-04T13:28:25Z

Include Java version number when generating the classes.jar file as classes_jdk8.jar.
closes: SharedClasses.SCM01.SingleCL UnsupportedClassVersionError eclipse-openj9/openj9#19582

annaibm · 2024-06-04T14:02:16Z

Grinder links:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41139/console - JDK8
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41122/ - JDK11
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41123/console - JDK 21,8

annaibm · 2024-06-10T14:23:00Z

Grinder links on master branches:
TARGET: extended.system on master branch
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41271/ -windows JDK8
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41270/ - linux JDK8

TARGET: SharedClasses.SCM01.SingleCL
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41273/ - JDK 17
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41274/ - JDK 21

Grinders run On PR branches for issue: 4912 -
aqa test: PR: 5239
TKG: PR: 564.
STF: PR: 135

TARGET: SharedClasses.SCM01.SingleCL
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41261/ -JDK 8
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41262/ -JDK11
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41263/ -JDK17
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/41264/ -JDK 21

llxia · 2024-06-11T20:08:38Z

03:32:01.370  GEN C:/Users/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1/classes_jdk8.jar does not exist
...
03:52:04.468  STF 17:50:46.067 - +------ Step 2 - Copy sharedClasses jar
03:52:04.468  STF 17:50:46.067 - | Copy a file to another directory
03:52:04.468  STF 17:50:46.067 - |   Source file: C:/Users/jenkins/workspace/Grinder/jvmtest/system/systemtest_prereqs/sharedClassesTestData/v1/classes_jdk8.jar

openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/stf/SharedClasses.java

openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/test/sc/JavaGen.java

llxia · 2024-06-11T20:13:05Z

openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/test/sc/JavaGen.java

+			if (jarDir.exists()) {
+				// Attempt to delete it
+				try {
+					deleteDirectory(jarDir);
+				} catch (IOException e) {
+					throw new RuntimeException("Failed to delete existing directory: " + e.getMessage());
+				}
+			}


please delete this and deleteDirectory() below

llxia · 2024-06-11T20:13:37Z

openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/test/sc/JavaGen.java

+		if (fileDir.exists()) {
+			try {
+				deleteDirectory(fileDir);
+			} catch (IOException e) {
+				throw new RuntimeException("Failed to delete existing directory: " + e.getMessage());
+			}
+		}


Please delete this block

openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/test/sc/JavaGen.java

llxia · 2024-06-11T20:17:35Z

openj9.test.sharedClasses/src/test.sharedClasses/net/openj9/stf/SharedClasses.java

@@ -211,7 +216,8 @@ public void setUp(StfCoreExtension test, StfSharedClassesExtension sharedClasses
 						.addProjectToClasspath("openj9.test.sharedClasses")
 						.runClass(JavaGen.class)
 						.addArg(sharedClassesDataDir.getSpec())
-						.addArg("10000"));
+						.addArg("10000")
+						.addArg(String.valueOf(javaVersion)));


Do we need to add javaVersion as an arg?

I am passing the javaVersion as an argument to be used by JavaGen.class file, or should we set it as environment Variable or as a static field ?

- Include Java version number as in classes_jdk8.jar while generating the classes.jar file. closes: eclipse-openj9/openj9#19582 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>

annaibm · 2024-06-12T14:23:14Z

Closing this PR , will raise new PR to address the issue.

annaibm force-pushed the system_test_javaversion branch 2 times, most recently from e19c94a to 7f6dfcd Compare June 7, 2024 20:54

annaibm changed the title ~~Add Java version to resolve UnsupportedClassVersion~~ Include Java version on generating classes jar file to resolve UnsupportedClassVersion Jun 10, 2024

llxia requested a review from pshipton June 11, 2024 20:08

annaibm marked this pull request as ready for review June 11, 2024 20:10

llxia reviewed Jun 11, 2024

View reviewed changes

llxia requested a review from LongyuZhang June 11, 2024 20:19

Generate classes_jdk.jar instead of classes.jar

e6065ad

- Include Java version number as in classes_jdk8.jar while generating the classes.jar file. closes: eclipse-openj9/openj9#19582 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>

annaibm force-pushed the system_test_javaversion branch from df52b0c to e6065ad Compare June 11, 2024 22:30

annaibm closed this Jun 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include Java version on generating classes jar file to resolve UnsupportedClassVersion #155

Include Java version on generating classes jar file to resolve UnsupportedClassVersion #155

annaibm commented Jun 4, 2024 •

edited

annaibm commented Jun 4, 2024

annaibm commented Jun 10, 2024 •

edited

llxia commented Jun 11, 2024

llxia Jun 11, 2024

llxia Jun 11, 2024

llxia Jun 11, 2024

annaibm Jun 11, 2024 •

edited

annaibm commented Jun 12, 2024

Include Java version on generating classes jar file to resolve UnsupportedClassVersion #155

Include Java version on generating classes jar file to resolve UnsupportedClassVersion #155

Conversation

annaibm commented Jun 4, 2024 • edited

annaibm commented Jun 4, 2024

annaibm commented Jun 10, 2024 • edited

llxia commented Jun 11, 2024

llxia Jun 11, 2024

Choose a reason for hiding this comment

llxia Jun 11, 2024

Choose a reason for hiding this comment

llxia Jun 11, 2024

Choose a reason for hiding this comment

annaibm Jun 11, 2024 • edited

Choose a reason for hiding this comment

annaibm commented Jun 12, 2024

annaibm commented Jun 4, 2024 •

edited

annaibm commented Jun 10, 2024 •

edited

annaibm Jun 11, 2024 •

edited