This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
clicking on headings in the tour abruptly shoots you to the top of the page #432
Comments
|
Works for me on Basics and Named Arguments – however, I think the link should probably be just the anchor, so the page isn’t reloaded. |
|
Ok, I guess it works on Chrome but not Safari. After clearing caches on Safari, it does work once, but then starts acting up. |
|
Works in FF too. If this is still a problem someone with Safari will need to debug it. |
lucaswerkmeister
added a commit
that referenced
this issue
Nov 11, 2016
Instead of linking to the full URL + anchor, just link to the anchor. No need to reload the site for this. I suggested this in #432 and then didn’t do anything about it for months, and I don’t even know why I implemented the full URL version in #309 in the first place – you can see that the actual fix, aside from a comment update, is purely to remove some code – but anyways, it’s better now, so there we are.
Merged
|
I think it's hitting the server, and the server is redirecting to a url without the Loading works, but redirects to (depending on the state of the cache, I guess; not 100% reproducible). |
|
I agree with @lucaswerkmeister that #443 will probably fix this. |
|
I had no idea that #443 would fix this, but with your explanation it does sound likely :D |
lucaswerkmeister
added a commit
that referenced
this issue
Nov 15, 2016
Instead of linking to the full URL + anchor, just link to the anchor. No need to reload the site for this. I suggested this in #432 and then didn’t do anything about it for months, and I don’t even know why I implemented the full URL version in #309 in the first place – you can see that the actual fix, aside from a comment update, is purely to remove some code – but anyways, it’s better now, so there we are.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Mouseovers for the links on the tour show URLs with bookmarks (
#....), but clicking on a link takes you to the page w/o a bookmark. Probably a bad onClick handler.The text was updated successfully, but these errors were encountered: