HashSet.remove() is broken

[gavinking]

I think this is the correct implementation:

doc "Removes an element from this set, if present"
shared actual void remove(Element element){
    Integer index = storeIndex(element, store);
    variable Cell<Element>? bucket := store[index];
    variable Cell<Element>? prev := null;
    while(exists Cell<Element> cell = bucket){
        if(cell.car == element){
            // found it
            if(exists Cell<Element> last = prev){
                last.cdr := cell.cdr;
            }else{
                store.setItem(index, cell.cdr);
            }
            _size--;
            return;
        }
        bucket := cell.cdr;
        prev := cell;
    }
}

[FroMage]

Ah, then why didn't you fix it?

[FroMage]

I guess you were shy ;) Now fixed.