Fix #1818 by substituting a temporary variable and assigning the fiel…

…d to it after successful completion of the loop, as we do for non-shared attributes.

compiler-java/src/com/redhat/ceylon/compiler/java/codegen/ClassTransformer.java

@@ -1826,6 +1826,15 @@ public void transform(AttributeDeclaration decl, ClassDefinitionBuilder classBui
                     classBuilder.field(modifiers, attrName, type, initialValue, !useField, makeAtIgnore());
                 }        
             }
+
+            // A shared attribute might be initialized in a for statement, so
+            // we might need a def-assignment subst for it
+            List<JCAnnotation> annots = makeJavaTypeAnnotations(decl.getDeclarationModel());
+            JCStatement outerSubs = statementGen().openOuterSubstitutionIfNeeded(
+                    decl.getDeclarationModel(), model.getType(), annots, 0);
+            if (outerSubs != null) {
+                classBuilder.init(outerSubs);
+            }
         }
 
         boolean withinInterface = Decl.withinInterface(decl);

compiler-java/src/com/redhat/ceylon/compiler/java/codegen/StatementTransformer.java

@@ -2734,7 +2734,7 @@ public List<JCStatement> transform(Tree.AttributeDeclaration decl) {
         return result.toList();
     }
 
-    private JCStatement openOuterSubstitutionIfNeeded(
+    JCStatement openOuterSubstitutionIfNeeded(
             Value value, ProducedType t,
             List<JCAnnotation> annots, int modifiers) {
         JCStatement result = null;