Skip to content

Commit

Permalink
[no bug] cleanup some warnings in setup.js
Browse files Browse the repository at this point in the history
  • Loading branch information
squarti committed Jun 28, 2016
1 parent 9cc055f commit fa86ea4
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions bundles/org.eclipse.orion.client.ui/web/edit/setup.js
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,6 @@ objects.mixin(EditorSetup.prototype, {
},

createSideBar: function() {
var commandRegistry = this.commandRegistry;
// Create input manager wrapper to handle multiple editors
function EditorInputManager() {
EventTarget.attach(this);
Expand Down Expand Up @@ -713,7 +712,7 @@ objects.mixin(EditorSetup.prototype, {
*/
computeNavigationHref: function(item, options) {
var openWithCommand = mExtensionCommands.getOpenWithCommand(this.commandRegistry, item);
if (openWithCommand && typeof(openWithCommand.hrefCallback) === 'function') {
if (openWithCommand && typeof openWithCommand.hrefCallback === 'function') {
return openWithCommand.hrefCallback({items: objects.mixin({}, item, {params: options})});
}
if(options) {
Expand Down Expand Up @@ -869,14 +868,14 @@ objects.mixin(EditorSetup.prototype, {
var unsavedMessage = dirty ? (autoSave ? messages.unsavedAutoSaveChanges : messages.unsavedChanges) : undefined;
if(util.isElectron && dirty){
window.__electron.remote.dialog.showMessageBox(
window.__electron.remote.getCurrentWindow(),
{
type: 'warning',
buttons: [messages["OK"]],
title: messages["Orion"],
message: unsavedMessage
});
}
window.__electron.remote.getCurrentWindow(),
{
type: 'warning',
buttons: [messages["OK"]],
title: messages["Orion"],
message: unsavedMessage
});
}
return unsavedMessage;
}.bind(this);
},
Expand Down Expand Up @@ -1095,7 +1094,7 @@ var setup;
exports.getEditorViewers = function() {
if (!setup) return [];
return setup.editorViewers;
}
};

exports.setUpEditor = function(serviceRegistry, pluginRegistry, preferences, readonly) {
enableSplitEditor = localStorage.enableSplitEditor !== "false"; //$NON-NLS-0$
Expand Down

0 comments on commit fa86ea4

Please sign in to comment.