Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Remove separate altitude parameter from Astro binding #3710

Closed
kaikreuzer opened this issue Jun 20, 2017 · 0 comments
Closed

Remove separate altitude parameter from Astro binding #3710

kaikreuzer opened this issue Jun 20, 2017 · 0 comments

Comments

@kaikreuzer
Copy link
Contributor

When approving my auto-discovered Sun thing, I got this in my log:

15:52:30.491 [INFO ] [smarthome.event.ThingAddedEvent     ] - Thing 'astro:sun:local' has been added.
15:52:30.493 [INFO ] [me.event.ThingStatusInfoChangedEvent] - 'astro:sun:local' changed from UNINITIALIZED to INITIALIZING
15:52:30.500 [ERROR] [ding.astro.handler.AstroThingHandler] - Astro parameters geolocation could not be split into latitude and longitude, disabling thing 'astro:sun:local'
15:52:30.501 [INFO ] [me.event.ThingStatusInfoChangedEvent] - 'astro:sun:local' changed from INITIALIZING to OFFLINE

The issue is that the discovery now adds ",," in the geoLocation config parameter of the Thing, while it expects the altitude to be filled into the dedicated "altitude" parameter instead.

As we will soon have a location context, which also includes altitude information, I think it would make most sense to remove the "altitude" parameter of Astro things and rather mark the geoLocation parameter to be of context "location", which implicitly can hold an optional altitude value.

triller-telekom added a commit to triller-telekom/smarthome that referenced this issue Jun 20, 2017
Fixes eclipse-archived#3710

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
kaikreuzer pushed a commit that referenced this issue Jun 21, 2017
* Remove altitude parameter from astro binding

Fixes #3710

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

* Use double for altitude

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant