This repository has been archived by the owner on May 7, 2020. It is now read-only.
Inbox auto ignored results are never removed #4187
Labels
Comments
afuechsel
added a commit
to afuechsel/smarthome
that referenced
this issue
Sep 5, 2017
…ng registry to handle REMOVED events correctly Fixes: eclipse-archived#4187 Signed-off-by: Andre Fuechsel <andre.fuechsel@telekom.de>
maggu2810
pushed a commit
that referenced
this issue
Sep 6, 2017
* AutomaticInboxProcessor registered as an RegistryListener for the thing registry to handle REMOVED events correctly Fixes: #4187 Signed-off-by: Andre Fuechsel <andre.fuechsel@telekom.de>
|
This fix might have caused a small issue with the hue binding, please see #4375 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When adding e.g. a hue bridge manually, its result is automatically set to IGNORED in the inbox as expected. When removing the bridge, the IGNORED entry in the inbox must be automatically deleted so a new discovery can find it again. It turns out, that this is not happening most of the time.
The reason is, that we do not have such a thing as a Pre-Delete-Hook, where we could easily check and remove possible ignored entries.Listening to ThingStatusChangedEvents as currently implemented does not help, because a REMOVED event indicates that a thing is already removed and REMOVING is not always fired and sometimes directly followed by a REMOVED. In most cases we are accessing the ThingRegistry too late to get informations about the thing being removed (it just returns null).
The text was updated successfully, but these errors were encountered: