This repository has been archived by the owner on May 7, 2020. It is now read-only.
Allow options to be outside of min/max in validator #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/eurotronic-spirit-z-wave-plus-doesnt-work/37477/6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Min/max validation should allows values outside of min/max if they are in the defined options. As an example, in Zwave we have lots of parameters that have a range of (say) 0 to 100, but have an option of setting 255 to disable. With the current implementation, I would need to set min/max to 0/255, which allows any value. It seems better to me to allow values to be outside of the range to cover this case.
This was discussed a long time ago when I added the 'limit to options' configuration in the parameter for exactly this purpose.
Signed-off-by: Chris Jackson chris@cd-jackson.com