This repository has been archived by the owner on May 7, 2020. It is now read-only.
Avoid having no value displayed in UIs for auto-created string items (fix #3248) #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix #3248) Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Hm, I think we should have a close look if this does not have any unexpected side-effects. I actually just came across a bug where there are already "too many" states shown, see the first floor on our demo sitemap:
So my point is that there are many valid use cases where we do not want the state to be provided/displayed; we should make sure that this is not broken. |
|
I think we should rather fix the auto creation of items when auto link mode is enabled. |
|
@kaikreuzer : please note that the problem you mentionned has nothing to do with my PR. I just installed snapshot 889 in my production environment and I can reproduce the problem in Basic UI. I open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr