This repository has been archived by the owner on May 7, 2020. It is now read-only.
Fix GenericItemProvider missing added event on startup #4163
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikreuzer
reviewed
Aug 31, 2017
| @@ -157,6 +157,8 @@ public void removeBindingConfigReader(BindingConfigReader reader) { | |||
| } | |||
| } | |||
| } | |||
| itemsMap.put(modelName, items); | |||
There was a problem hiding this comment.
This looks like a brute force fix to me. Note that the itemsMap is also filled in modelChanged, so you are now doing it several times.
Wouldn't the better place the getAll() method as this is the one that gets called (once) before added events are received? And if this would additionally check, whether an entry in the map already exists, it would be even nicer.
There was a problem hiding this comment.
You are right and in addition the line introduces just another bug when multiple *.items models are present. Only one model would be written to itemsMap. Update is on the way.
There was a problem hiding this comment.
Oh noes, wrote that before I had the first coffee... Its a map idiot (<- note to myself).
- fixes eclipse-archived#4162 - also fixes duplicate added events for items see eclipse-archived#4161 (comment) and closes eclipse-archived#617 - minor cosmetics Signed-off-by: Henning Treu <henning.treu@telekom.de>
kaikreuzer
approved these changes
Sep 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes the GenericItemProvider independent from the ADDED event the ModelRepositoryImpl emits on startup. When the GenericItemProvider reads its models it will add the items to its internal map and prevent NPEs on further modified events.
Fixes #4162.
Also:
Signed-off-by: Henning Treu henning.treu@telekom.de