Added @NonNull to property labels and getThingTypeUID #4262
Conversation
Added @nonnull to property labels and getThingTypeUID Minor changes: * Interface fields are always public static final, leave out the modifiers * Corrected @return to @param in setLabel docblock * Corrected fieldname in setBridgeUID docblock Closes #4099 Signed-off-by: Martin van Wingerden <martinvw@mtin.nl>
|
Shouldn't we wait with nullable annotations until we finalize the coding guidelines? |
|
Yes maybe we should, I did not follow the complete discussion my view was limited to linked issue, where a PR was 'requested' 🙂 |
|
@maggu2810 I guess I encouraged him at a time when we thought that the discussions were already through - but in the light of the recent discussions on #4080, I would agree that we might want to wait with that right now. |
|
With these new guidelines, I would claim that this PR is obsolete. |
|
You might want to create a new PR with your other "minor changes" though - as they do not fit to the title of this PR, I preferred to close it and ask you for a new one :-) |
Done, see #4293 |
Added @nonnull to property labels and getThingTypeUID
Minor changes:
Closes #4099