This repository has been archived by the owner on May 7, 2020. It is now read-only.
Null annotations: alter severity of IDE warnings #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: Make null reference check happy. Signed-off-by: Henning Treu <henning.treu@telekom.de>
maggu2810
reviewed
Oct 12, 2017
| notifyListenersAboutUpdatedElement(oldElement, element); | ||
| logger.debug("Updated element {} in {}.", key, this.getClass().getSimpleName()); | ||
| return oldElement; | ||
| if (persistableElement != null) { // redundant but makes null reference check happy. |
There was a problem hiding this comment.
This is not redundant.
The storage member could be changed between storage.get(key) and storage.put(key, ....
Or am I wrong? I don't see any synchronized statements that ensure storage isn't changed.
So, I agree with the change but IMHO the comment should be removed.
There was a problem hiding this comment.
Yes, you are right. The comment actually refers only to storage.get(key) but parallel modification does indeed require this call. I will remove the comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the proposal mentioned here #4321 (comment) to reduce the severity of some null annotation warnings. Also the "Null Reference" check was raised to
Error.Also: Make null reference check happy in
AbstractManagedProvider.Signed-off-by: Henning Treu henning.treu@telekom.de