This repository has been archived by the owner on May 7, 2020. It is now read-only.
Improve DMX binding #4455
Merged
Improve DMX binding #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
htreu
reviewed
Oct 25, 2017
| * @author Jan N. Klug | ||
| */ | ||
| public enum ActionState { | ||
| waiting, |
There was a problem hiding this comment.
enum values should be all upper case.
| @@ -253,8 +254,10 @@ public synchronized Integer getNewHiResValue(long calculationTime) { | |||
| if (hasRunningActions()) { | |||
| BaseAction action = actions.get(0); | |||
| value = action.getNewValue(this, calculationTime); | |||
| if (action.isCompleted()) { | |||
| if (ActionState.completed.equals(action.getState())) { | |||
There was a problem hiding this comment.
since ActionState are enum values this should be if (action.getState() == ActionState.COMPLETED) {. please check other comparison, too.
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
|
Oops. Forgot to commit & push my changes. |
sjsf
approved these changes
Nov 1, 2017
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
|
Now it seems to be complete, TravisCI likes it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring: rename class Channel to DmxChannel to avoid problems with ESH-class Channel
add tests for FadeAction
make Chaser turn to off after completed with infinite holdTime (-1)